search

carpentries-incubator / cwl-novice-tutorial

Introduction to Workflows with Common Workflow Language
https://carpentries-incubator.github.io/cwl-novice-tutorial/
Other
11 stars 20 forks source link

Reference fruitfly RNA in episode 3 #118

Closed douglowe closed 2 years ago

douglowe commented 2 years ago

The inputs for rna_seq_workflow.cwl are renamed to include fruitfly in their names. And the explanatory text at the start has been expanded, to explicitly link to the previous episode, explaining the changes we're making here.

Instructions Thanks for contributing! :heart: Keep in mind that **lesson maintainers are volunteers** and it may take them some time to respond to your contribution. Although not all contributions can be incorporated into the lesson materials, we appreciate your time and effort to improve the curriculum. If you have any questions about the lesson maintenance process or would like to volunteer your time as a contribution reviewer, please contact the CWL Team via https://www.commonwl.org/#Support. You may delete these instructions from your comment.
netlify[bot] commented 2 years ago

Add Deploy Preview notifications as pull request comments when Deploy Preview succeeds

Name Link
Latest commit 1055fd08d8ae6b8b063259ace377fc337e40d6ff
Latest deploy log https://app.netlify.com/sites/thirsty-hoover-1e0704/deploys/62bb245e9e237f0008af69b9
Deploy Preview https://deploy-preview-118--thirsty-hoover-1e0704.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

douglowe commented 2 years ago

Hopefully this addresses this issue: https://github.com/carpentries-incubator/cwl-novice-tutorial/issues/101

douglowe commented 2 years ago

@mr-c has updated the figures - I think these look good now.

douglowe commented 2 years ago

It all looks good now, though I still don't understand the need to rename those steps. Are we doing anything non-fruitfly for this tutorial? If not, then it just makes the input names unnecessarily longer without adding any clarity. If anything it reduces clarity by implying other steps are not to do with the fruitfly example.

I think the input name changes are useful - it keeps a connection with the previous example. I think it would be good for us to try this version tomorrow, and see what the feedback is from our users on the name changes.