carpentries-incubator / deep-learning-intro

Learn Deep Learning with Python
https://carpentries-incubator.github.io/deep-learning-intro/
Other
30 stars 37 forks source link

Use functions in episode 4 #357

Closed svenvanderburg closed 11 months ago

github-actions[bot] commented 11 months ago

Thank you!

Thank you for your pull request :smiley:

:robot: This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

Rendered Changes

:mag: Inspect the changes: https://github.com/carpentries-incubator/deep-learning-intro/compare/md-outputs..md-outputs-PR-357

The following changes were observed in the rendered markdown documents:

 4-advanced-layer-types.md | 167 ++++++++++++++++++++++++++--------------------
 md5sum.txt                |   2 +-
 2 files changed, 94 insertions(+), 75 deletions(-)
What does this mean? If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

:stopwatch: Updated at 2023-08-07 09:08:18 +0000

svenvanderburg commented 11 months ago

I agree that the create_nn function does not add as much as the plot_history and compile_model functions. However, I do think that it shows good practice and conceptually puts all network creation code in one function which makes the explanation a bit easier I think. And it is in line with the other episodes.