search

carpentries-incubator / deep-learning-intro

Learn Deep Learning with Python
https://carpentries-incubator.github.io/deep-learning-intro/
Other
31 stars 36 forks source link

Fix heatmap plotting bug #470

Closed qualiaMachine closed 5 months ago

qualiaMachine commented 5 months ago

I ran into an odd bug while prepping to teach this workshop last week. With the current workshop environment running on Windows 10, I ran into this issue: https://stackoverflow.com/questions/77165100/only-the-first-row-of-annotations-displayed-on-seaborn-heatmap

Updating both matplotlib and seaborn seemed to resolve the issue: pip install seaborn --upgrade pip install matplotlib --upgrade

I propose we add these pip statements to the setup instructions.

github-actions[bot] commented 5 months ago

Thank you!

Thank you for your pull request :smiley:

:robot: This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

Rendered Changes

:mag: Inspect the changes: https://github.com/carpentries-incubator/deep-learning-intro/compare/md-outputs..md-outputs-PR-470

The following changes were observed in the rendered markdown documents:

 md5sum.txt |  4 ++--
 setup.md   | 17 +++++++----------
 2 files changed, 9 insertions(+), 12 deletions(-)
What does this mean? If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

:stopwatch: Updated at 2024-06-11 16:45:03 +0000

qualiaMachine commented 5 months ago

I may be hitting my limit in GitHub knowledge. As a maintainer, can you pull just your change/commit and exclude my initial commit? I don't think we want to merge both commits — just yours. Let me know if I should do anything to help the process! Thanks.

svenvanderburg commented 5 months ago

@qualiaMachine I just created a new commit that removes step 5 (in general if you are unsure about git, just create a new commit resulting in the endresult that you want. I think the improvements that you made to the instructions are actually valuable.

qualiaMachine commented 5 months ago

Ah, makes sense! Thanks for wrapping up the pull request.