carpentries-incubator / deep-learning-intro

Learn Deep Learning with Python
https://carpentries-incubator.github.io/deep-learning-intro/
Other
30 stars 37 forks source link

Add diagonal ref. line to plot_predictions() function #476

Open qualiaMachine opened 1 month ago

qualiaMachine commented 1 month ago

It's very useful to have a diagonal reference line when viewing scatterplots that plot true vs predicted data. Deviations above/below the diagonal tell you where the model is making more mistakes.

github-actions[bot] commented 1 month ago

Thank you!

Thank you for your pull request :smiley:

:robot: This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

Rendered Changes

:mag: Inspect the changes: https://github.com/carpentries-incubator/deep-learning-intro/compare/md-outputs..md-outputs-PR-476

The following changes were observed in the rendered markdown documents:

 3-monitor-the-model.md | 1 +
 md5sum.txt             | 4 ++--
 2 files changed, 3 insertions(+), 2 deletions(-)
What does this mean? If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

:stopwatch: Updated at 2024-06-04 18:42:59 +0000

qualiaMachine commented 3 weeks ago

Correct, @svenvanderburg, it updates all the plots in the episode (that show true vs predicted points) since I updated the plot_predictions() function directly. See attached an example plot from the episode. plot_with_ref_line

svenvanderburg commented 3 weeks ago

Yes, I think it is a neat addition! If you have the time can you add the updated plots? (I think it is confusing if we only add the code and not the corresponding plots). If you don't have time we can pick it up during our next sprint.

By the way @qualiaMachine did you see we have an upcoming sprint 22 & 23rd of July? https://github.com/carpentries-incubator/deep-learning-intro?tab=readme-ov-file#lesson-development-sprints . Maybe you would like to join (in any form of capacity you have)?

qualiaMachine commented 3 weeks ago

Happy to add the plots this week :). I wish I could make the sprints, but 10 CEST will be 3am in my time zone. Might have to skip that one haha.

svenvanderburg commented 3 weeks ago

Happy to add the plots this week :). I wish I could make the sprints, but 10 CEST will be 3am in my time zone. Might have to skip that one haha.

Check. If you are interested we could meet around 16:00 CEST, which would be 9:00 in your time zone then?