Modify v3 Dockerfile example to take advantage of cache - closes #125

carpentries-incubator / docker-introduction

Reproducible Computational Environments using Containers

https://carpentries-incubator.github.io/docker-introduction/

Other

42 stars 48 forks source link

Modify v3 Dockerfile example to take advantage of cache - closes #125 #173

Closed jcohen02 closed 2 years ago

jcohen02 commented 2 years ago

Reordered statements in v3 Dockerfile example in "Creating More Complex Container Images" in order to take effective advantage of layers. Thanks for highlighting this @MiddelkoopT, and suggesting the change.

sstevens2 commented 2 years ago

Think this commit was was made to a branch that was a bit behind. I think the conflict is because we changed the filenames in the missing commits. Maybe rebase @jcohen02?

jcohen02 commented 2 years ago

Apologies @sstevens2, I realised after creating the PR that things were out of date and didn't want to rebase and force push to the PR branch in case that caused any issues - I thought it may manage to merge this small change successfully. Have now rebased, all looks OK so will merge. Thanks.