carpentries-incubator / fair-research-software

A course on tools and practices for open, sustainable and FAIR (Findable, Accessible, Interoperable and Reusable) research software
https://carpentries-incubator.github.io/fair-research-software/
Other
10 stars 6 forks source link

The "bad" code is not refactored in the version control or the code readability episode #89

Open kkh451 opened 3 months ago

kkh451 commented 3 months ago

The "bad" code is not refactored by the end of the code readability episode.

The "poor practices" within the code see https://github.com/carpentries-incubator/astronaut-data-analysis-not-so-good/issues/2 are not directly highlighted e.g. "code structure could be improved - no functions and everything in one monolithic piece of code" and "commenting and uncommenting code to direct the flow of execution / type of analysis being done"

Ideally, the testing episode should begin with the whole code base refactored into sensible functions.

Possible solutions:

anenadic commented 2 months ago

Is this fixed now?