search

carpentries-incubator / gap-lesson

Programming with GAP
https://carpentries-incubator.github.io/gap-lesson/
Other
6 stars 10 forks source link

Use remote theme #31

Closed fmichonneau closed 5 years ago

fmichonneau commented 5 years ago

addresses #29

This pull request brings in the remote theme for this lesson.

olexandr-konovalov commented 5 years ago

Thank you @fmichonneau ! I've checked out the PR and did the following:

$ make serve
bundle exec jekyll serve
Configuration file: /Users/alexk/GITREPS/SWC_DC/gap-lesson/_config.yml
            Source: /Users/alexk/GITREPS/SWC_DC/gap-lesson
       Destination: /Users/alexk/GITREPS/SWC_DC/gap-lesson/_site
 Incremental build: disabled. Enable with --incremental
      Generating... 
Invalid theme folder: _sass
      Remote Theme: Using theme carpentries/carpentries-theme
Invalid theme folder: _sass
                    done in 2.399 seconds.
 Auto-regeneration: enabled for '/Users/alexk/GITREPS/SWC_DC/gap-lesson'
    Server address: http://127.0.0.1:4000
  Server running... press ctrl-c to stop.

Except the message about _sass folder, the result looks OK to me.

olexandr-konovalov commented 5 years ago

Also while navigating, the following messages printed in the terminal:

[2019-10-23 20:15:15] ERROR `/edit/setup.md' not found.
[2019-10-23 20:15:15] ERROR `/favicon.ico' not found.
ErinBecker commented 5 years ago

Thanks for testing @alex-konovalov. It sounds like things generally worked, so I'm going to go ahead and merge this PR so we can start communicating about the Incubator lessons more broadly with the community. I'll leave this branch open so that @fmichonneau can address those navigation errors if needed.

olexandr-konovalov commented 5 years ago

Thanks @ErinBecker - the content looks OK, and I am not familiar with the new theme to decide if all works as intended or not. The Carpentries Incubator logo is not there, so perhaps some more tweaks will be needed, but hopefully it will stabilise shortly.