search

carpentries-incubator / geospatial-python

Introduction to Geospatial Raster and Vector Data with Python
https://carpentries-incubator.github.io/geospatial-python/
Other
159 stars 57 forks source link

Contribution from Netherlands eScience Center #110

Closed rogerkuou closed 2 years ago

rogerkuou commented 2 years ago

This PR includes the course refactoring from the Netherlands eScience Center. The contributions are made by @fnattino @SarahAlidoost @cpranav93 @raar1 @rogerkuou.

Summary of the changes:

  1. The Episodes are restructured.
    • There are now 11 Episodes available, 1 still WIP.
    • Episodes 1 to 4 remain mostly the same.
    • Episode 5 is a new episode, focusing on satellite data retrival.
    • Episode 6 to 10 are inspired by the current material, focusing on the same Python tools and trying to cover the same learning goals.
    • Episode 11 is another new episode, focusing on parallel computation for raster data.
  2. To make the example case a bit more eye catchy, we changed the AoI to Northern Amsterdam, because the ground coverage has more varieties in this location. We also replaced the NEON Lidar datasets with the following open data:
  3. Miscellaneous improvements:
    • Data has been backed up on Figshare: https://doi.org/10.6084/m9.figshare.20146919.v1
    • Restructured the figures. Now all the figures are in the fig directory, with the naming convention is 'episode_number-image_number_in_episode-name_of_image', i.e. E01-01-imagename.jpg
    • Added an initial version of instructor notes
rbavery commented 2 years ago

Fantastic. Thank you @fnattino @SarahAlidoost @cpranav93 and @rogerkuou for pushing this lesson forward and overhauling each of these lessons to make it a modern geospatial python lesson.

I'll be reviewing this throughout the month. can you remind me when you intend to teach this version?

rbavery commented 2 years ago

@rogerkuou can we remove all the files in the _episodes/_extras folder? are these older versions that are now numbered and exist in _episodes? Or do they have another purpose? If they should be kept, I'm wondering if I should review these at all or if I should focus on the top level _episodes folder.

rogerkuou commented 2 years ago

@rogerkuou can we remove all the files in the _episodes/_extras folder? are these older versions that are now numbered and exist in _episodes? Or do they have another purpose? If they should be kept, I'm wondering if I should review these at all or if I should focus on the top level _episodes folder.

Hi @rbavery, good point. I have removed the folder _episodes/_extras since they are only initial templates. On a related token, I would tend to keep _episodes/_legacy for now since it contains the previous version of some episodes. Just in case we need to have something back.

rogerkuou commented 2 years ago

Fantastic. Thank you @fnattino @SarahAlidoost @cpranav93 and @rogerkuou for pushing this lesson forward and overhauling each of these lessons to make it a modern geospatial python lesson.

I'll be reviewing this throughout the month. can you remind me when you intend to teach this version?

And my apology for missing @raar1 in the initial PR description. Sorry Robin! I know you won't mind but it's not that Ryan excluded you on purpose!

And @rbavery feel free to take your time for the review! We are planning to teach this course for once in November, but this does not mean the review must be done before that. Meanwhile, if you think there is any major issue blocking your review, just leave us a message.

rbavery commented 2 years ago

@rogerkuou @fnattino I'm almost done reviewing but wanted to point out a blocker to merging.

Polygon: Crop fields data is too large to download. since it is a half gigabyte and is located on a PDOK server with a slow bandwidth connection or the fact that it is located in the Netherlands causes it to be slow to download. It would take an hour for me to download this file on the USA west coast. Details here, maybe we can discuss a solution in this issue: https://github.com/esciencecenter-digital-skills/geospatial-python/issues/61

fnattino commented 2 years ago

Hi @rbavery , thank you very much for reviewing this big PR and for raising and addressing the issue on the size of the vector dataset. I should have implemented all your suggestions - please merge when/if you deem this is ready!