search

carpentries-incubator / geospatial-python

Introduction to Geospatial Raster and Vector Data with Python
https://carpentries-incubator.github.io/geospatial-python/
Other
159 stars 57 forks source link

Update lesson to the new template #158

Closed fnattino closed 1 year ago

fnattino commented 1 year ago

@rogerkuou and I have brought the lesson to the Carpentries Workbench.

When making the translation, we have not made content changes, but for the setup instructions, which we have tried to simplify (this would also close #154 ).

@rbavery we are curious to hear if you have any feedback! The new template is currently deployed from our repository fork, you can check it out at: https://esciencecenter-digital-skills.github.io/geospatial-python/

rbavery commented 1 year ago

@fnattino @rogerkuou this looks amazing! I really like the reworked setup instructions, they seem much simpler to follow. I noticed the curl command to download the datasets was removed, overall I think that makes sense since Windows users had a fair amount of trouble with this during the last workshop.

No comments that need addressing now, I really like the new template and I think this is good to merge.

I noticed in some places the template introduces a lot of whitespace under images. and some text is squished together when code brackets are used:

This contains the information on where and how to access the target images from a remote repository. We can use the functionpystac.ItemCollection.from_file()to load the search results as anItem` list.

rogerkuou commented 1 year ago

@rbavery Thanks a lot for the review! I found the code brackets rendering issue you mentioned was caused by a missing space, that should be fixed now. For the white space under the figures, I did not notice any significant ones. I suspect that can sometimes be caused by how the template handles the description text, and I am not sure if the browser/OS difference plays a role here. For example, this figure in Ep6, for me the description text showed in a grey box. I am not sure if it shows up as big white space on your side? image I will merge this PR for now. We can check on these issues later! Thanks again for the review!