search

carpentries-incubator / git-novice-branch-pr

Version Control with Git
https://carpentries-incubator.github.io/git-novice-branch-pr
Other
5 stars 17 forks source link

Fix typos in pull requests lesson #17

Closed djhoese closed 5 years ago

djhoese commented 5 years ago

I was updating these lessons in my own fork to talk about GitLab instead of GitHub and noticed a few typos. Other than spelling mistakes there were two other changes:

  1. There is a numbered list that wasn't being rendered as one because of the spacing and indentation. I fixed this.
  2. The lesson talks about being able to set reviewers for your pull request. I'm 99% sure you can only do this if you have the privileges on the upstream repository. I've removed this sentence.
djhoese commented 5 years ago

Yep, I don't have permissions on this repository and can't set anything on the right side except for unchecking "Allow edits from maintainers" and unsubscribing from notifications.

sstevens2 commented 5 years ago

Looks great! Thanks for taking the time to make these changes while you were preparing.