search

carpentries-incubator / git-novice-branch-pr

Version Control with Git
https://carpentries-incubator.github.io/git-novice-branch-pr
Other
5 stars 17 forks source link

gets ssh stuff from git-novice #42

Closed srappel closed 2 years ago

srappel commented 2 years ago

This incubator lesson still had learners using HTTPS to clone. I grabbed the SSH stuff from the current git-novice episode.

@sstevens2 can you take a look at this? I haven't looked at later episodes to see if there are dependencies yet.

sstevens2 commented 2 years ago

@srappel Did you teach it this week? How did it go? Did it work well teaching the ssh setup in the github section? I'd love to hear your experience.

srappel commented 2 years ago

@sstevens2 I taught it last week as a 2-day, 4 hour (total) workshop. We didn't have enough time to get through everything. I only introduced branches and we never made it to Pull Requests. But the rest of the material went really well.

Also worth noting that it was the first exclusively in-person thing we've done in a while. I'm glad we did it that way, it was my first experience doing in-person Carpentries.

It took less time than I thought it would to set up SSH in the GitHub episode. It would probably be okay in the setup instructions, but I think a lot of people would need some extra help, there's lots of room for error and it's not very clear exactly what's happening during the process. I'm seeing now that you mean the setup episode. That makes more sense. I'm working on this now.

srappel commented 2 years ago

@sstevens2 I think this PR is ready to merge! And I would be happy to be a maintainer on this lesson.

sstevens2 commented 2 years ago

Thanks @srappel! I'll see if I can get you added as a maintainer!

sstevens2 commented 2 years ago

@tobyhodges I added @srappel directly to maintain this repo but I can't seem to add him to the carpentries-incubator/git-novice-branching-maintainers group because he isn't a part of the organization. Would you need to add him to the carpentries incubator org first?

tobyhodges commented 2 years ago

Thanks for pinging me @sstevens2 I have sent @srappel and invitation to the org and team.