Reworking of includes and layouts episodes as per #208

carpentries-incubator / jekyll-pages-novice

Building Websites with Jekyll & GitHub Pages.

https://carpentries-incubator.github.io/jekyll-pages-novice/

Other

16 stars 21 forks source link

Reworking of includes and layouts episodes as per #208 #242

Closed anenadic closed 3 years ago

anenadic commented 3 years ago

Reworking of includes and layouts episodes:

code reuse examples now use top navigation links instead of banner and footer
layouts inheritance is shown on the example of home layout inheriting from default layout and adding a banner image

Example code repository for reference: https://github.com/anenadic/group-website

anenadic commented 3 years ago

Thanks for the review @tobyhodges ❤️ . I have committed all your changes (let me know if I've missed anything). I suggest I go now and resolve conflicts and merge the latest changes from gh-pages branch and then ask you to have another quick look and merge. Then the whole team can have look at the narrative and flow and fix any issues. Does that sound like a plan?

anenadic commented 3 years ago

Latest changes (8b475cdec190403bae91e421ccd9516f5afafe7e and 90bd4f78901bfefe77de24f488415a32495e554f):

Merged from gh-pages and resolved all conflicts.
Added more screenshots to showcase adding of a header and a footer.
Restyled the footer section not to be in the form of an exercise but rather the main text (as there is quite a lot going on that may require the instructor to show).
Reverted the footer section name to 'Reusing Footer' instead of 'Reusable Footer' to be consistent with other headings in the episode. Review request pls @tobyhodges.