carpentries-incubator / lc-webscraping

Introduction to web scraping
https://carpentries-incubator.github.io/lc-webscraping/
Other
37 stars 28 forks source link

Replace dead link image with local host one #43

Closed PhilReedData closed 3 years ago

PhilReedData commented 3 years ago

In the XPath Axes section, there is an image included whose source is on another site and no longer exists: https://kimpham54.github.io/library-webscraping/fig/xpath-axes.jpg The image is surrounded by a link to a local copy of the same image. I have confirmed it is the same image by checking the Wayback Machine. I have replaced the image source with the local image. Not sure if there is a need to keep the surrounding link because the image is the same size wherever viewed.

PhilReedData commented 3 years ago

Sorry, I just noticed #42 is the same as this issue.

timtomch commented 3 years ago

No worries, it was my mistake not to have merged that PR sooner. Sorry for the duplicate work!