carpentries-incubator / managing-computational-projects

Managing Open and Reproducible Computational Projects
https://carpentries-incubator.github.io/managing-computational-projects
Other
8 stars 10 forks source link

merging chapters/episodes #99

Closed jcolomb closed 1 year ago

jcolomb commented 1 year ago

see https://github.com/carpentries-incubator/managing-computational-projects/pull/98, one can call md files in an episode and merge them.

Issue is that the question/objective part does not work (duplicate + at 2 places anyway)

We can move the objective to the Rmd file and keep the questions in the subchapter files. Then we get 2 boxes with the same objectives, but different questions.

jcolomb commented 1 year ago

@zkamvar this works locally, but it seems the github action fails, can you have a look ? (https://github.com/carpentries-incubator/managing-computational-projects/pull/98)

update: it worked locally, but not anymore.

zkamvar commented 1 year ago

I found the issue. There were two of them:

  1. the child markdown documents were not part of the schedule, so they were explicitly ignored and not copied over to the build directory (which is the feature that allows people to work on episode drafts without affecting build time).
  2. the reference to one of the child documents needed to be "Rmd"

I've opened https://github.com/carpentries-incubator/managing-computational-projects/pull/100 that will fix this by merging directly into #98

zkamvar commented 1 year ago

Note: this is somewhat related to https://github.com/carpentries/sandpaper/issues/256 and tangentially related to https://github.com/carpentries/sandpaper/issues/367.

jcolomb commented 1 year ago

works now #98 thanks