search

carpentries-incubator / python-intermediate-development-earth-sciences

Intermediate Research Software Development Skills In Python for Earth Sciences
https://carpentries-incubator.github.io/python-intermediate-development-earth-sciences/
Other
4 stars 3 forks source link

Change layout of diagram #44

Closed OscarSeip closed 3 months ago

OscarSeip commented 4 months ago

Arrange explanation of colours and headings vertically instead of horizontally to line up with the arrangement of the flow chart.

Here: https://carpentries-incubator.github.io/python-intermediate-development-earth-sciences/14-collaboration-using-git/index.html#feature-branch-software-development-workflow

Screenshot 2024-02-28 at 09 25 29
OscarSeip commented 4 months ago

Also consider changing the same diagram here: https://carpentries-incubator.github.io/python-intermediate-development-earth-sciences/41-code-review/index.html

douglowe commented 3 months ago

Thanks for the suggestion, but as the long term move will be to use the graphics in the original material (https://carpentries-incubator.github.io/python-intermediate-development/fig/code-review-sequence-diagram.svg) we'll leave these as they are for now rather than rejig them.