carpentries-incubator / scientific-metadata

Introduction to the Fundamentals of Scientific Metadata
https://carpentries-incubator.github.io/scientific-metadata/
Other
6 stars 0 forks source link

[Content Review] Carpentries perspective #3

Closed SilkeGerlich closed 1 year ago

SilkeGerlich commented 1 year ago

This content review will be conducted through the eyes of the Carpentries. It regards the lesson and instructions in general

General review instructions

Where to start

Minor Changes If you find a typo or grammar mistakes, feel free to directly change them in the individual documents provided below.

Major Changes If you find larger issues with the content (representation, structure, clarity), comment preferably at the respective place in the pull request. Or use this issue for overarching comments or feature requests

While reviewing the content please also keep an eye on:

Through the eyes of an INSTRUCTOR :eyes:

Guiding questions

Keep these questions in the back of your mind, while reviewing the content

Focus points

List of documents for review

look at these documents in depth:

  1. Landing page: index.md
  2. Learner profiles: learner-profiles.Rmd
  3. General Lesson Information: general-lesson-information.Rmd (metadata on top will be updated during the review :wink:)
  4. Instructor Guide: instructor-guide.Rmd
  5. Episode 1: getting-started.Rmd
  6. Episode 2: data-metadata.Rmd
  7. Episode 3: structure-schema.Rmd
  8. Episode 4: enabling-technologies-standards.Rmd
  9. Episode 5: web-locations-identifiers.Rmd

disregard these files as they are still under construction:

  1. Acknowledgements: acknowledgements.Rmd
  2. Meet the Creators: meet-the-creators.Rmd
  3. Outlook - Linked Data: conclusion-outlook.Rmd will be included in lesson version 1.1

When you finish your review

Good to know

If you have immediate questions or need a quick fix, use the review Mattermost channel or comment in this issue.

:heart: Thank your so much for you support in the reviewing process :heart:

apirogov commented 1 year ago

High-level checks against the Curriculum Development Handbook

apirogov commented 1 year ago

There is a wrongly rendered hyperlink in for Data & Metadata: (the &), probably its a problem in the pipeline:

2023-03-07-122719_782x330_scrot 2023-03-07-122659_756x199_scrot

apirogov commented 1 year ago

What is the difference between "data object" and "dataset" in the scope of the lesson?

The "example data object" is just a "dataset" with bad metadata, isn't it?

apirogov commented 1 year ago

Is the "instructor guide" using actually duplicated snippets from the other resources?

Ideally, this could embed from the other files.

apirogov commented 1 year ago

Some files are duplicated. Is this for technical reasons?

SilkeGerlich commented 1 year ago

What is the difference between "data object" and "dataset" in the scope of the lesson?

The "example data object" is just a "dataset" with bad metadata, isn't it?

Can you specify this question? If it is regarding the "example data object", then the "data set" does not apply (anymore). We've change the terminology to data object because dataset and data object can not be used interchangeably -> data set > 1 file. In connection with the example data object "dataset" would be an artifact, which I will have to get rid off. Please mark this in the .Rmds

SilkeGerlich commented 1 year ago

Is the "instructor guide" using actually duplicated snippets from the other resources?

Ideally, this could embed from the other files.

Good point! Yes, they are actual duplicates. Will try if this works with the pipeline (not sure, if the rendering works :) )

apirogov commented 1 year ago

Learner view: link to glossary is broken (if there is no glossary, remove? otherwise fix?)

SilkeGerlich commented 1 year ago

There is a wrongly rendered hyperlink in for Data & Metadata: (the &), probably its a problem in the pipeline:

Tried to fix it with different approaches but failed. Probably something in the pandoc pipeline. Will be included in the Workbench Beta-Test Feedback.

apirogov commented 1 year ago

What is the difference between "data object" and "dataset" in the scope of the lesson? The "example data object" is just a "dataset" with bad metadata, isn't it?

Can you specify this question? If it is regarding the "example data object", then the "data set" does not apply (anymore). We've change the terminology to data object because dataset and data object can not be used interchangeably -> data set > 1 file. In connection with the example data object "dataset" would be an artifact, which I will have to get rid off. Please mark this in the .Rmds

I disagree about dataset = > 1 file, see e.g. https://en.wikipedia.org/wiki/Data_set or https://www.oxfordlearnersdictionaries.com/definition/american_english/data-set

It says nothing about files, and in fact a single file with multiple pieces of information in my eyes qualifies as "dataset", i.e. a CSV file is a dataset

In any case one can argue if you have one JSON object of the same kind in a file, its not really a "dataset", so I see your point.

btw, I "fixed" all data set to dataset (did not know the other spelling is ok + carpentries always write dataset as one word)

apirogov commented 1 year ago

There is a wrongly rendered hyperlink in for Data & Metadata: (the &), probably its a problem in the pipeline:

Tried to fix it with different approaches but failed. Probably something in the pandoc pipeline. Will be included in the Workbench Beta-Test Feedback.

In the PR I suggested, you could also simply substitute & into and as a workaround (unless you have a strong preference)

hofmannv commented 1 year ago

i agree: a data set is not characterised by the number of files it is saved at. It is consists of multiple pieces of data (in one or multiple files) that are grouped according to some characteristic.

from HDO: definition "A generically dependent continuant which is composed always of multiple datum instances, which are grouped intentionally according to one or more common characteristics."@en rdfs:comment "Intention may be related to analysis, storage or publication of that data(set). For example, all files that are stored together on one CD-ROM or DVD might constitute a dataset as they are stored physically together. The organisation of the collection might strongly differ between application cases."@en

However i don't see a problem with calling the example data either example data, example data set or example data object (while the last one sounds like there is something more formal to it...).