Closed SilkeGerlich closed 1 year ago
High-level checks against the Curriculum Development Handbook
[X] clearly follows the Backward design principle / building course with target learning objectives in mind
[X] uses elements of live coding and "didactic thinking aloud"
[X] clearly defined target audience, learning objectives and key points
[X] extensive instructor material
[ ] not domain-specific / immediately relatable to scientists daily work but possible spin-offs could fit the content into various domain contexts
[ ] Challenges are somewhat more complex than "typical" carpentries challenge (e.g. filling in blanks / multiple choice) but group-work based approach makes it more approachable. The provided challenges clearly try to put theory into practice i.e. putting it into a (different) context
There is a wrongly rendered hyperlink in for Data & Metadata
: (the &
), probably its a problem in the pipeline:
What is the difference between "data object" and "dataset" in the scope of the lesson?
The "example data object" is just a "dataset" with bad metadata, isn't it?
Is the "instructor guide" using actually duplicated snippets from the other resources?
Ideally, this could embed from the other files.
Some files are duplicated. Is this for technical reasons?
What is the difference between "data object" and "dataset" in the scope of the lesson?
The "example data object" is just a "dataset" with bad metadata, isn't it?
Can you specify this question? If it is regarding the "example data object", then the "data set" does not apply (anymore). We've change the terminology to data object because dataset and data object can not be used interchangeably -> data set > 1 file.
In connection with the example data object "dataset" would be an artifact, which I will have to get rid off. Please mark this in the .Rmd
s
Is the "instructor guide" using actually duplicated snippets from the other resources?
Ideally, this could embed from the other files.
Good point! Yes, they are actual duplicates. Will try if this works with the pipeline (not sure, if the rendering works :) )
Learner view: link to glossary is broken (if there is no glossary, remove? otherwise fix?)
There is a wrongly rendered hyperlink in for
Data & Metadata
: (the&
), probably its a problem in the pipeline:
Tried to fix it with different approaches but failed. Probably something in the pandoc pipeline. Will be included in the Workbench Beta-Test Feedback.
What is the difference between "data object" and "dataset" in the scope of the lesson? The "example data object" is just a "dataset" with bad metadata, isn't it?
Can you specify this question? If it is regarding the "example data object", then the "data set" does not apply (anymore). We've change the terminology to data object because dataset and data object can not be used interchangeably -> data set > 1 file. In connection with the example data object "dataset" would be an artifact, which I will have to get rid off. Please mark this in the
.Rmd
s
I disagree about dataset = > 1 file, see e.g. https://en.wikipedia.org/wiki/Data_set or https://www.oxfordlearnersdictionaries.com/definition/american_english/data-set
It says nothing about files, and in fact a single file with multiple pieces of information in my eyes qualifies as "dataset", i.e. a CSV file is a dataset
In any case one can argue if you have one JSON object of the same kind in a file, its not really a "dataset", so I see your point.
btw, I "fixed" all data set
to dataset
(did not know the other spelling is ok + carpentries always write dataset as one word)
There is a wrongly rendered hyperlink in for
Data & Metadata
: (the&
), probably its a problem in the pipeline:Tried to fix it with different approaches but failed. Probably something in the pandoc pipeline. Will be included in the Workbench Beta-Test Feedback.
In the PR I suggested, you could also simply substitute &
into and
as a workaround (unless you have a strong preference)
i agree: a data set is not characterised by the number of files it is saved at. It is consists of multiple pieces of data (in one or multiple files) that are grouped according to some characteristic.
from HDO: definition "A generically dependent continuant which is composed always of multiple datum instances, which are grouped intentionally according to one or more common characteristics."@en rdfs:comment "Intention may be related to analysis, storage or publication of that data(set). For example, all files that are stored together on one CD-ROM or DVD might constitute a dataset as they are stored physically together. The organisation of the collection might strongly differ between application cases."@en
However i don't see a problem with calling the example data either example data
, example data set
or example data object
(while the last one sounds like there is something more formal to it...).
This content review will be conducted through the eyes of the Carpentries. It regards the lesson and instructions in general
General review instructions
Where to start
site/docs/index.html
) in Instructor View.Minor Changes If you find a typo or grammar mistakes, feel free to directly change them in the individual documents provided below.
Major Changes If you find larger issues with the content (representation, structure, clarity), comment preferably at the respective place in the pull request. Or use this issue for overarching comments or feature requests
While reviewing the content please also keep an eye on:
Through the eyes of an INSTRUCTOR :eyes:
Guiding questions
Keep these questions in the back of your mind, while reviewing the content
Focus points
List of documents for review
look at these documents in depth:
disregard these files as they are still under construction:
When you finish your review
Good to know
If you have immediate questions or need a quick fix, use the review Mattermost channel or comment in this issue.
:heart: Thank your so much for you support in the reviewing process :heart: