carpentries-incubator / simple-linear-regression-public-health

Simple linear regression for public health
https://carpentries-incubator.github.io/simple-linear-regression-public-health
Other
0 stars 7 forks source link

Superfluous c() calls? #35

Closed nathansam closed 2 years ago

nathansam commented 2 years ago

In https://carpentries-incubator.github.io/simple-linear-regression-public-health/05-fitAndAssumptionSLR/index.html

There are two cases where effect_plot() is called with colors = c("red"). This led to some confusion amongst learners who wanted to know why c() was being used with a single argument. Given it isn't needed, I think it makes sense to just replace with colors = "red"