carpentries-incubator / targets-workshop

Pre-alpha {targets} workshop
https://carpentries-incubator.github.io/targets-workshop/
Other
33 stars 8 forks source link

future -> crew #15

Closed multimeric closed 1 year ago

multimeric commented 1 year ago

Changes

Discussion

In my opinion this:

tar_option_set(
  controller = crew::crew_controller_local(workers = 2)
)

Is much neater than:

library(crew)
tar_option_set(
  controller = crew_controller_local(workers = 2)
)

However I've done the latter for consistency.

github-actions[bot] commented 1 year ago

Thank you!

Thank you for your pull request :smiley:

:robot: This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

Rendered Changes

:mag: Inspect the changes: https://github.com/joelnitta/targets-workshop/compare/md-outputs..md-outputs-PR-15

The following changes were observed in the rendered markdown documents:

 basic-targets.md   |    4 +-
 branch.md          |   30 +-
 config.yaml (gone) |   87 ---
 files.md           |   18 +-
 files/functions.R  |    5 +-
 introduction.md    |    2 +-
 lifecycle.md       |   12 +-
 md5sum.txt         |   40 +-
 packages.md        |   12 +-
 parallel.md        |   59 +-
 renv.lock (gone)   | 1790 ----------------------------------------------------
 11 files changed, 97 insertions(+), 1962 deletions(-)
What does this mean? If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

:stopwatch: Updated at 2023-06-19 06:32:14 +0000

multimeric commented 1 year ago

@joelnitta

joelnitta commented 1 year ago

Thanks! I needed to make the corresponding change to the function that is use to actually run the workflows, write_example_plan().