Nextflow review @bobturneruk ep1 - Githubissues

carpentries-incubator / workflows-nextflow

Workflow management with Nextflow and nf-core

https://carpentries-incubator.github.io/workflows-nextflow/

Other

18 stars 29 forks source link

Nextflow review @bobturneruk ep1 #113

Open ggrimes opened 2 months ago

ggrimes commented 2 months ago

ep1 I get this output from the script, which is different to the course material. Might be good if the output number wasn't 0?

(nf-training) bobturner@tubby:~/nf-training$ nextflow run word_count.nf
N E X T F L O W  ~  version 20.10.0
Launching `word_count.nf` [boring_nobel] - revision: 72656509cb
executor >  local (1)
[14/523859] process > NUM_LINES (1) [100%] 1 of 1 ✔
SRR2584863_1.fastq.gz   0

Perhaps this helps? https://github.com/bobturneruk/workflows-nextflow/commit/6be012f49314006b35cf162546bf8d1ec9086d7d
I think there are some duplicate items in the list of script contents. I suggest https://github.com/bobturneruk/workflows-nextflow/commit/087842116f0cc4767d2811d5c51f0425cd9a9cee

ggrimes commented 2 months ago

@bobturneruk the commit https://github.com/carpentries-incubator/workflows-nextflow/commit/6be012f49314006b35cf162546bf8d1ec9086d7d fixes it

https://github.com/carpentries-lab/reviews/issues/16