search

carpentries-lab / metagenomics-analysis

Data Processing and Visualization for Metagenomics
https://carpentries-lab.github.io/metagenomics-analysis/
Other
9 stars 29 forks source link

Improve Writing Scripts and Working with Data #48

Closed Czirion closed 1 year ago

Czirion commented 2 years ago

Reviewr's comments: 1) In the Writing Scripts and Working with Data episode, there is no proposed text to write in nano. Although it's understood that this allows for more creativity from the learners, it may be useful to add an example for guidance. Such an example will also assist in the flow of the section on "Writing files", as it is currently a bit unclear.

2) In the Writing Scripts and Working with Data episode, the sentence "You will learn more about writing scripts in a later lesson." links back to the same episode.

3) In the Writing Scripts and Working with Data episode, the "Transferring data between your local machine and the cloud" needs to be adapted to also fit the case of a local installation - or be provided with a possible alternative.

4) In the Writing Scripts and Working with Data episode, the section on "Versioning scripts with Git and GitHub" would lead to a confusion, given the target audience. Although knowledge of Git is undoubtedly a useful skill, it may not be easily connected here.

Czirion commented 1 year ago
  1. Added text and screenshot
  2. Removed line
  3. Pending...
  4. Removed Git part
fabel134 commented 1 year ago

Creo que ya termine :)

nselem commented 1 year ago

Please, explain what did you do, for the reviewers

fabel134 commented 1 year ago

This Issue was fixed by adding steps to be able to download and upload data from an R Studio online terminal. Also added a note that talks about alternatives to download and upload data.

fabel134 commented 1 year ago

The sizes of the figures will be adjusted so that they can be readable

nselem commented 1 year ago

Great work. Now you need to have all images in English. The last ones have a legend "seleccionar archivo" en español and we need all images in English.