search

carpentries-lab / python-aos-lesson

Python for Atmosphere and Ocean Scientists
https://carpentries-lab.github.io/python-aos-lesson/
Other
87 stars 49 forks source link

[JOSE] xarray module is imported as `xr` but tied to call as `xarray` #23

Closed RobTheOceanographer closed 5 years ago

RobTheOceanographer commented 5 years ago

In lesson 07-vectorisation the first call to xarray.open_dataset has a syntax error as the xarray module is imported as xr: Change xarray.open_dataset to xr.open_dataset ?

CC: openjournals/jose-reviews#37

RobTheOceanographer commented 5 years ago

there is actually a second instance of this further down in this lesson that need addressing too.

DamienIrving commented 5 years ago

Thanks for spotting this error, @RobTheOceanographer.

I've corrected both calls to xr.open_dataset (see https://github.com/carpentrieslab/python-aos-lesson/commit/d43e966ae1aa46594a50f7014b03e6af94e75b76).