carpentries-lab / python-aos-lesson

Python for Atmosphere and Ocean Scientists
https://carpentries-lab.github.io/python-aos-lesson/
Other
87 stars 49 forks source link

Add preview #30

Closed eldobbins closed 1 month ago

eldobbins commented 4 years ago

This PR addresses 2 related issues: previewing lessons on a local machine (in this case MacOS Mohave) and running the python-based lesson checking scripts included in https://github.com/carpentries/lesson-example

make lesson-check runs but does not finish successfully. I hope to submit future PRs that correct the errors.

DamienIrving commented 4 years ago

Thanks, @eldobbins.

I've requested a review from @fmichonneau because if I'm totally honest, I know very little about how the build works. Up until now I've just been pushing changes to GitHub and then waiting to see if the changes appear as I thought they would at the github.io site, which obviously isn't a sustainable development process going forward once other people want to make contributions.

DamienIrving commented 1 month ago

Closing this pull request as I'm about to transition to the Carpentries Workbench.