search

carpentries-lab / python-aos-lesson

Python for Atmosphere and Ocean Scientists
https://carpentries-lab.github.io/python-aos-lesson/
Other
87 stars 48 forks source link

Fix some typos and added a few suggestions #5

Closed ocefpaf closed 6 years ago

ocefpaf commented 6 years ago

Hi @DamienIrving,

I made a few updates to the install instructions. I'll add some comments on the lines I changed to make it easier to review.

Ping @rsignell-usgs who may be using this soon.

DamienIrving commented 6 years ago

Thanks, @ocefpaf! I've made some comments - if you agree and want to edit your PR accordingly I'll go ahead and merge :-)

DamienIrving commented 6 years ago

@ocefpaf @rsignell-usgs The only major issue with the lessons right now (in case you're thinking of using them) is #3. I'm actively looking for someone who knows something about Git BASH to figure out whether the issue can be overcome, or whether for the sake of windows users the use of conda environments should be removed (i.e. everything would just be installed in the root anaconda environment, as is done for any other Software Carpentry python lesson).

ocefpaf commented 6 years ago

Ready for another round of reviews.

ocefpaf commented 6 years ago

@ocefpaf @rsignell-usgs The only major issue with the lessons right now (in case you're thinking of using them) is #3. I'm actively looking for someone who knows something about Git BASH to figure out whether the issue can be overcome, or whether for the sake of windows users the use of conda environments should be removed (i.e. everything would just be installed in the root anaconda environment, as is done for any other Software Carpentry python lesson).

I don't use git-bash but I do know that some people successfully at conda to the right paths and things just work. Also, the new syntax for activating and deactivating envs may help here.