carpentries-lab / reviews

Open peer review of lessons from The Carpentries community.
Other
14 stars 4 forks source link

[Review]: Machine Learning Responsible Python #23

Open gperu opened 1 year ago

gperu commented 1 year ago

Lesson Title

Responsible machine learning in Python

Lesson Repository URL

https://github.com/carpentries-incubator/machine-learning-responsible-python

Lesson Website URL

https://carpentries-incubator.github.io/machine-learning-responsible-python/

Lesson Description

This lesson explores key topics on the responsible application of machine learning. The lesson is presented as a series of case studies that illustrate real world examples. Sections cover a broad range of topics, including reproducibility, bias, and interpretability. Broadly the topics are ordered chronologically, appearing as they would when thinking through a research study.

Author Usernames

@tompollard

Zenodo DOI

No response

Differences From Existing Lessons

No response

Confirmation of Lesson Requirements

JOSE Submission Requirements

Potential Reviewers

No response

tobyhodges commented 1 year ago

Thank you for submitting this lesson for review, @gperu.

My capacity for managing lesson reviews is quite limited at the moment and I will not be able to handle reviews of all of your submitted lessons simultaneously. If you have a preference for which lesson(s) you would like us to prioritise for review, please let me know and I will do my best to focus on that/those first.

astroDimitrios commented 5 months ago

Popping this here with my editor checks which I will be updating over the next couple of weeks :) @tompollard

Editor Checklist - Responsible machine learning in Python

Accessibility

The decision tree image is a bit fuzzy. Is there a clearer version with larger axis labels that could be used? The attacks bannana image could also be replaced if there is a higher resolution version.

Content

Episodes 5 and onwards don't have any exercises listed on the episode page but they do show time for exercises at the top of the page. Maybe these are in Python and not written up?

There are a few spelling mistakes that need to be fixed.

Design

Could you add some more detail to the homepage on the target audience for the lesson - Is this for someone with no background in ML?

Repository

The lesson repository includes:

Structure

Supporting information

The lesson includes:

Could you add a line about how to unzip a .gz file for the data on Windows/Linux?

General

This has the makings of a great lesson and I think it's a nice idea using the case studies and linking to other papers for further reading.

I'm a bit confused as to where the Python comes in - the setup mentions Python but none of the episodes mention Python at all. Is that because this is the first in a series of ML lessons? Or is there Python somewhere that I'm missing.

There are a few bits missing that say FIXME that need looking at:

astroDimitrios commented 3 days ago

Hi @tompollard @gperu I've had a chance to go through the checklist and update the comment above. Sorry for the delay. Let me know if you have questions about what I have written and thanks again for submitting this for review!