carpentries / actions

GitHub Actions for use in Carpentries-style lessons
1 stars 8 forks source link

Builds for R lessons failing on ubuntu 22.04 due to {remotes} #67

Closed zkamvar closed 1 year ago

zkamvar commented 1 year ago

Problem

As described in 2cc84b6b16b1b02a3092067b8d6f9157b2449c6a, the release of the Ubuntu 22.04 image as default causes builds to fail because the CRAN version of {remotes} (released last year) does not have the 22.04 version, which was added in April 2022: https://github.com/r-lib/remotes/pull/705

Solutions attempted

I have attempted the following solutions:

  1. Install {remotes} from r-universe: 2971fa19ddb2405e8a5b89dcb99d69372ff17503
  2. replace the function using unlockBinding: 15d99f7ddbdcee0c6f3b2cc669c476fe30bfa882

But for some reason, neither of these seem to work and I have no clue why 😞

zkamvar commented 1 year ago

Update, it turns out that my error was a simple one: I forgot to include the ! in the conditional for checking if we need to modify: 51b2c389551a23823fdf9894748a99060d57b0a0