Closed milanmlft closed 1 year ago
@tobyhodges You're absolutely right! Should be fixed now.
@milanmlft thanks again for the PR. In the interest of security, this actions repository is set up to require commits to be verified. To work around it, I think we will have to create another PR with the same changes.
If you expect to be contributing to this or other similar projects again, I recommend you consider adding the relevant setup to your GitHub account. If you follow the link I've provided above, you will find details of how to configure your account.
I'm really sorry we can't credit your contribution in the commit history.
Oh woops, I was wondering recently why I didn't have that "verified" badge. Thanks for sharing the link, I will get it set up asap.
No worries about the credit, was just a minor fix anyway 🙂
Oh woops, I was wondering recently why I didn't have that "verified" badge. Thanks for sharing the link, I will get it set up asap.
No worries about the credit, was just a minor fix anyway 🙂
Sorry about this @milanmlft - I've tried to rebase and squash the commits to sign it as a single commit but it still seems to complain :(
All good, thanks for trying!
@froggleston @tobyhodges just as a final remark; maybe it would be a good idea to add some CONTRIBUTING
guidelines to the repo to point out this requirement about signed commits? Unless it already exists somewhere and I completely missed it 😅
Fixes #74 See also https://github.com/r-lib/remotes/commit/e199c1bdda3858600bbef8e4bbc3f5868b899587