search

carpentries / actions

GitHub Actions for use in Carpentries-style lessons
1 stars 8 forks source link

ENH: Fix `Node.js` warnings linked to GitHub actions #94

Closed jhlegarreta closed 2 days ago

jhlegarreta commented 2 months ago

Fix Node.js warnings linked to GitHub actions: bump versions actions/checkout@v4, and actions/upload-artifact@v4

Fixes:

Update Workflow
Node.js 16 actions are deprecated.
Please update the following actions to use Node.js 20:
actions/checkout@v3, carpentries/create-pull-request@main.
For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

and

Build Full Site
The following actions use a deprecated Node.js version and will be forced to run on node20:
 actions/cache@v3.0.11.
 For more info:
 https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

raised for example in: https://github.com/carpentries-incubator/SDC-BIDS-fMRI/actions/runs/9753104282 and https://github.com/carpentries-incubator/SDC-BIDS-IntroMRI/actions/runs/10578432348

jhlegarreta commented 2 months ago

Maybe PR #91 was not enough?

jhlegarreta commented 2 months ago

BTW, the OS in the actions is Ubuntu 20.04. Updating it may be appropriate.

ErinBecker commented 2 weeks ago

Thank you @jhlegarreta for making these fixes. I'm unfortunately not able to merge contributions from accounts with unverified signatures. If you'd like to resubmit after verifying your signature, I'd be happy to merge. Else, I'll go ahead and make these changes in another branch and merge with credit to you.

jhlegarreta commented 2 weeks ago

:+1: Will submit with verified signature later today or over the weekend, Erin. Thanks for your work.

jhlegarreta commented 2 weeks ago

Done. Thanks @ErinBecker.

ErinBecker commented 2 days ago

Thanks @jhlegarreta!