search

carpentries / amy

A web-based workshop administration application built using Django.
https://amy.carpentries.org
MIT License
113 stars 72 forks source link

Roll over seats/workshops after new membership created #2004

Closed maneesha closed 1 year ago

maneesha commented 3 years ago

With the new membership features, we have the ability to create a new membership from an existing one, rolling over any or all of the unused instructor training seats and workshops. This is useful when we know that we'll be rolling over the seats and/or workshops at the point of creating a new membership.

Sometimes we decide to roll over unused seats after the new membership is created. We would like to have a way to roll over seats after the new membership is created.

pbanaszkiewicz commented 3 years ago

Wouldn't https://github.com/carpentries/amy/issues/1936 solve this issue?

maneesha commented 3 years ago

We would want to be able to roll over seats when a new membership entry was created independent of the old one.

So we had an existing membership, University X from 2020-07-01 to 2021-06-30. We created a new membership for University X from 2021-07-01 to 2022-06-30 by creating an entirely new entry, not by rolling over the old one. We'd like to now make this be a rolled over membership.

This is likely going to be the case for a few current memberships, where the roll over feature was not implemented yet. I'd also be happy to do a data migration for now and not add in another feature, knowing that all future memberships should be using the new rollover feature.

pbanaszkiewicz commented 3 years ago

@maneesha if data migration suits you, I'd rather do it this way. Unless you're certain the same situation can happen in future.

EDIT: alternatively I can enable rolled_to_membership field edit on membership edit form. This way you could manually set the rollover membership, but you'd be more prone to error.

maneesha commented 3 years ago

I think the same situation happening in the future is highly unlikely, so a data migration should be fine. The only reason for it now is because of current memberships that were entered in before the rollover feature was enabled. @pbanaszkiewicz what information (and in what format) do you need from me to do the migration?

pbanaszkiewicz commented 3 years ago

@maneesha I'll need to know memberships (old, new) and how many seats I should roll over from all categories.

maneesha commented 1 year ago

I am closing this because it is old and I don't think we need it as we have been rolling over memberships for two years now.