search

carpentries / feeds.carpentries.org

A repo to generate dynamic JSON data feeds for The Carpentries
https://feeds.carpentries.org
MIT License
3 stars 2 forks source link

add python script for lesson contributor count #22

Closed maneesha closed 5 years ago

maneesha commented 5 years ago

See conversation in https://github.com/carpentries/carpentries.org/issues/449

maneesha commented 5 years ago

Do not merge - this builds successfully but the python code itself broke somewhere along the way returning incorrect counts.

maneesha commented 5 years ago

@fmichonneau Do you know why a build isn't being triggered for the latest two commits in this PR?

fmichonneau commented 5 years ago

you can go here: https://travis-ci.com/carpentries/amy-feeds/requests to see the events that Travis receives and triggers the builds. It looks like there is an issue with the formatting of the .travis.yml file: in the after_success step, a - is missing in front of the command.

maneesha commented 5 years ago

Thanks for catching that.

It builds now but cat lesson_contributor_count.json returns an empty file. It does work locally, populating the json file with the Python dict as expected.

I'm going to merge this to see if it works on deploy (as it does not seem to break anything else)