carpentries / feeds.carpentries.org

A repo to generate dynamic JSON data feeds for The Carpentries
https://feeds.carpentries.org
MIT License
3 stars 2 forks source link

fix gh actions #77

Closed zkamvar closed 1 year ago

zkamvar commented 1 year ago

This reverts #75 and #76 and provides the fallback as proposed in #73

In the future, if there are failing feeds, use the || to shortcut on error and report an EXIT_STATUS > 1 to the healthchecks.

maneesha commented 1 year ago

Thanks @zkamvar We know it's the lesson feeds that fail the most, but should we consider adding this line to each make line? I had started to look to see if there is a way to do this for all lines without adding it to each line.

zkamvar commented 1 year ago

We know it's the lesson feeds that fail the most, but should we consider adding this line to each make line? I had started to look to see if there is a way to do this for all lines without adding it to each line.

Yes. I think that would be worthwhile.

zkamvar commented 1 year ago

We know it's the lesson feeds that fail the most

It's the incubator feed that fails the most. The lessons feed has been consistent for the most part until now.

zkamvar commented 1 year ago

but should we consider adding this line to each make line?

This was also proposed in #72

zkamvar commented 1 year ago

Unfortunately, this PR has reached its rate limit for the hour, so I will revisit this in an hour.

zkamvar commented 1 year ago

It looks like this workflow can realistically only run once per hour. I think this has been fixed, so I'm going to merge it in an hour when I take my break.