carpentries / feeds.carpentries.org

A repo to generate dynamic JSON data feeds for The Carpentries
https://feeds.carpentries.org
MIT License
3 stars 2 forks source link

workflow_dispatch on to allow manual run of action #80

Closed maneesha closed 11 months ago

maneesha commented 11 months ago

In addition to having scheduled actions, I would like us to have the ability to manually run an action (so we don't have to wait for the next scheduled run if we fix a bug or make a change in between). According to the instructions on how to manually run a workflow, it says workflow_dispatch must be on. I would like to have someone who knows more about GH Actions than me to review this and be sure it won't cause a conflict with the scheduled runs. Tagging @zkamvar or @froggleston or @elichad

maneesha commented 11 months ago

I don't know if the failing checks are because of the meta nature of this PR (running an action on a change in action) or something else. I don't see anything wrong with the workflow. Further reading:

zkamvar commented 11 months ago

I don't see anything particularly wrong with the workflow either. It looks like the echo github context is getting borked because of some weird character not properly escaped. I would say this is fine to merge.

zkamvar commented 11 months ago

ugh, it turns out it wasn't benign. Let's delete that show github context. it's not doing anything but hurting us.