Reset exposed API keys & move to secrets - Githubissues

carpentries / feeds.carpentries.org

A repo to generate dynamic JSON data feeds for The Carpentries

https://feeds.carpentries.org

MIT License

3 stars 2 forks source link

Reset exposed API keys & move to secrets #90

Open maneesha opened 6 days ago

maneesha commented 6 days ago

For some scripts where we are not exposing private data, we do expose the API key. For example AMY curricula and workshops.

As general practice, we should never expose API keys. Opening this issue to do the following:

[ ] Identify each script in this repo that exposes an API key
[ ] Identify any other places we may be using those Redash queries
[ ] Reset the API key in Redash
[ ] Add the API key to this repo's GH secrets
[ ] Update the scripts to use the secret instead of the hard coded key
[ ] Update the API key in any other places as needed

@froggleston is there anything else you can think of that we should do?

froggleston commented 2 days ago

That list looks good! 👍