ian-flores commented 4 years ago

This PR adds support for three use cases:

Summarizing a lesson #8
Linking to a definition #3
Checking a lesson #7

It also adds a GitHub action for a daily download of the package data so that it has the latest version.

codecov[bot] commented 4 years ago

Codecov Report

Merging #11 into master will decrease coverage by 17.17%. The diff coverage is 6.57%.

@@             Coverage Diff             @@
##           master      #11       +/-   ##
===========================================
- Coverage   72.76%   55.59%   -17.18%     
===========================================
  Files           8       11        +3     
  Lines         224      295       +71     
===========================================
+ Hits          163      164        +1     
- Misses         61      131       +70

Impacted Files	Coverage Δ
R/define.R	`66.66% <0.00%> (ø)`
R/list_glosario_terms.R	`0.00% <0.00%> (ø)`
R/text_definition.R	`0.00% <0.00%> (ø)`
R/validate_document.R	`0.00% <0.00%> (ø)`
R/entry.R	`58.04% <9.67%> (-13.89%)`	:arrow_down:
R/gdef.R	`81.81% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 44f6acd...527913c. Read the comment docs.

ian-flores commented 3 years ago

@fmichonneau and @zkamvar I think this is now at a point where we can merge. Agreed or any other changes that you can think of?

zkamvar commented 3 years ago

@fmichonneau and @zkamvar I think this is now at a point where we can merge. Agreed or any other changes that you can think of?

Agreed we can merge this to get it moving since RMD support is key. We need to add tests for this, though but that may depend on the outcome of https://github.com/carpentries/glosario/issues/27

fmichonneau commented 3 years ago

I left 2 small comments, but otherwise, this is good to merge! Thanks Ian!

carpentries / glosario-r

Support for RMarkdown and Offline Support #11

Codecov Report