Need to install again to be able to use new translated terms?

carpentries / glosario-r

glosario create and retrieve multilingual glossaries.

https://carpentries.github.io/glosario-r

Other

6 stars 5 forks source link

Need to install again to be able to use new translated terms? #17

Open beatrizmilz opened 3 years ago

beatrizmilz commented 3 years ago

Hi! I made a page for a workshop and added some Glosario terms there. Some were still not merged, so I left them in english. After the PR was merged, I tried to update this terms to portuguese (with lang = 'pt'), and the output was this message:

Some languages requested are not availble for this entry.NULL

I tried in two different days (not that makes much difference), and still got this message. So I installed again the package, and now the term is shown in portuguese alright :)

My question is: everytime that I want to use terms that were recently translated into glosario, I'll have to install the package again? Is there anyway to make this re-instalation not needed? Or I'm missing something that I should do?

Thanks!

zkamvar commented 3 years ago

Hi @beatrizmilz!

At the moment, you are correct, {glosario} must be re-installed to have access to the new terms because the glossary itself lives inside the package.

This is directly related to https://github.com/carpentries/glosario/issues/27 and I think the path forward is to store the glossary on a known folder on your computer and then have a function called glosario::update() that will check if the glossary.yaml file needs to be updated and download the new version.

What do you think? Does this sound like an okay workflow? Do @gvwilson, @ian-flores, and @fmichonneau have opinions?

beatrizmilz commented 3 years ago

Thanks @zkamvar for the answer!

I think it would be nice if it's possible to update without needing to re-install the package. And I like your idea :) More ideas for your idea for glosario::update() workflow:

This function could receive as an argument the path to store the yaml file of the glossary.
If the file is not there yet, download it
if the file is already downloaded in that path.. (pasting what you wrote):"check if the glossary.yaml file needs to be updated and download the new version." - possibly from https://github.com/carpentries/glosario/raw/master/glossary.yml , which is the most recent version, right?
Use that file as the glossary (like in get_glossary, but is it possible to use the argument glossary in the yaml to apply to all glossary terms in that rmd file? like it is with the argument 'lang')

What do you think?

ian-flores commented 3 years ago

Hi @beatrizmilz just an update that I'm including this idea into the 2021 update I'll be doing of glosario these next few weeks.