search

carpentries / instructor-training

Instructor Training
https://carpentries.github.io/instructor-training/
Other
175 stars 290 forks source link

Rename "homework" to avoid evoking bad memories #1658

Closed annajiat closed 4 months ago

annajiat commented 5 months ago

Thank you @brownsarahm for suggesting to rename "homework" to evoke less bad memories at #1159 Based on the pr-requestd label, here is the pull request.

Changelog: Replaced "homework" with "preparation.." phrases inthe episode 12-homework and "practice " in the episode 15-carpentries. Closes #1159

github-actions[bot] commented 5 months ago

Thank you!

Thank you for your pull request :smiley:

:robot: This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

Rendered Changes

:mag: Inspect the changes: https://github.com/carpentries/instructor-training/compare/md-outputs..md-outputs-PR-1658

The following changes were observed in the rendered markdown documents:

 12-homework.md    | 4 ++--
 15-carpentries.md | 2 +-
 md5sum.txt        | 4 ++--
 3 files changed, 5 insertions(+), 5 deletions(-)
What does this mean? If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

:stopwatch: Updated at 2024-04-12 15:13:29 +0000

brownsarahm commented 5 months ago

Hi @annajiat thank you for the PR, it is best practice for long term maintainability that PR titles are more descriptive, can you edit?

annajiat commented 5 months ago

Done, thanks @brownsarahm