carpentries / instructor-training

Instructor Training
https://carpentries.github.io/instructor-training/
Other
173 stars 289 forks source link

close markdown in new instructor training rubric notes sample #1680

Closed ttriche closed 1 week ago

ttriche commented 1 week ago

If this pull request addresses an open issue on the repository, please add 'Closes #NN' below, where NN is the issue number.

Closed dangling markdown tag ( ** )

No issue previously opened

github-actions[bot] commented 1 week ago

Thank you!

Thank you for your pull request :smiley:

:robot: This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

Rendered Changes

:mag: Inspect the changes: https://github.com/carpentries/instructor-training/compare/md-outputs..md-outputs-PR-1680

The following changes were observed in the rendered markdown documents:

 demos_rubric.md | 2 +-
 md5sum.txt      | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
What does this mean? If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

:stopwatch: Updated at 2024-06-20 17:00:00 +0000

ttriche commented 1 week ago

I am a little mystified by why a branch must be created in a (my) fork, presumably this is a repo policy

brownsarahm commented 1 week ago

I think github pushes you to make a branch within the fork to make it work better when you update your fork's main from the carpentries main, but the flow within browser does also change at times in ways that are not strictly enforced if you were to work offline. As in, I think if you had committed to main in your fork, you could still make the PR.