search

carpentries / instructor-training

Instructor Training
https://carpentries.github.io/instructor-training/
Other
175 stars 290 forks source link

add 2024 Q4 events #1726

Closed maneesha closed 2 months ago

github-actions[bot] commented 2 months ago

:ok: Pre-flight checks passed :smiley:

This pull request has been checked and contains no modified workflow files, spoofing, or invalid commits.

Results of any additional workflows will appear here when they are done.

maneesha commented 2 months ago

I think it's ok to merge this despite the failing check... I'll revert if not.

brownsarahm commented 2 months ago

I'm not super well versed in the artifact version of using gh pages, but what I do understand I think that this error may mean that the rendered site might not reflect these changes? It's not clear to me why that step is running on a PR anyway.

but I agree it should be okay to merge this; that helps us collect more information and then we should be able to file an issue on the repo with the script code because nothing in this PR should be causing this problem. (unless the literally astronomically low probability event of a hash collision is the cause)

maneesha commented 2 months ago

Thanks @brownsarahm - yes, nothing broke when I merged it but the changes don't render.
It is an issue with the artifact workflow. We are seeing this in other lessons as well. I will take another look tomorrow.

froggleston commented 2 months ago

Fixed in sandpaper 0.16.7