Making make serve work - Githubissues

carpentries / lesson-example

Example lesson using The Carpentries lesson template.

https://carpentries.github.io/lesson-example/

Other

64 stars 173 forks source link

Making make serve work #293

Closed Denubis closed 4 years ago

Denubis commented 4 years ago

Related to #292. @kelseygonzalez and I tested these changes on Ubnutu, Windows 10, and Mac. make serve should now work. We did not test python because that was out of scope of the reported problem, though python maintainers should make sure there is a requirements.txt just like there's a gemfile.

fmichonneau commented 4 years ago

Thanks Brian. Sorry for the trouble, but could you please open this PR against the styles repo?

maxim-belkin commented 4 years ago

We need to figure out what's going on exactly here because I tested that Makefile in GitBash on a Windows machine in the past and it was working fine. I suspect hard-coded values might break things for others.

@Denubis, when you transfer the PR, could you please remove all the extra comments and unrelated changes (such as whitespace changes, additional @s, and output redirections)?