carpentries / lesson-example

Example lesson using The Carpentries lesson template.
https://carpentries.github.io/lesson-example/
Other
64 stars 173 forks source link

upgrade to latest styles #299

Closed fmichonneau closed 4 years ago

fmichonneau commented 4 years ago

I imported the latest styles and copied over the latest travis file. I'm not sure why this fails... At least one of the reasons seems a ruby version issue. The error log indicates that it's trying to use ruby 2.5.0 but rvm is set to use 2.7.1 and it seems to have picked it up correctly. The ruby script starts with #!/usr/bin/env ruby which should detect the version specified by rvm.

Locally (I don't use rvm), I still have an error generated by the python script though:

Traceback (most recent call last):                                                                                                                                                                                                                                                
  File "bin/lesson_check.py", line 566, in <module>                                                                                                                                                                                                                               
    main()                                                                                                                                                                                                                                                                        
  File "bin/lesson_check.py", line 116, in main                                                                                                                                                                                                                                   
    check_source_rmd(args.reporter, args.source_dir, args.parser)                                                                                                                                                                                                                 
  File "bin/lesson_check.py", line 201, in check_source_rmd                                                                                                                                                                                                                       
    data = read_markdown(parser, f)                                                                                                                                                                                                                                               
  File "/home/francois/git/lesson-example/bin/util.py", line 122, in read_markdown                                                                                                                                                                                                
    doc = json.loads(stdout_data)                                                                                                                                                                                                                                                 
  File "/usr/lib/python3.8/json/__init__.py", line 357, in loads                                                                                                                                                                                                                  
    return _default_decoder.decode(s)                                                                                                                                                                                                                                             
  File "/usr/lib/python3.8/json/decoder.py", line 340, in decode                                                                                                                                                                                                                  
    raise JSONDecodeError("Extra data", s, end)                                                                                                                                                                                                                                   
json.decoder.JSONDecodeError: Extra data: line 1 column 4 (char 3)                                                                                                                                                                                                                
make: *** [Makefile:139: lesson-check-all] Error 1