Fixing warnings raised by `make lesson-check-all` command.

carpentries / lesson-example

Example lesson using The Carpentries lesson template.

https://carpentries.github.io/lesson-example/

Other

64 stars 173 forks source link

Fixing warnings raised by `make lesson-check-all` command. #330

Closed vinisalazar closed 3 years ago

vinisalazar commented 3 years ago

Fixes relative to #321. Discussion is ensuing over there.

Changes in this PR include:

Shorten line lengths
Modify code block tags
Add None as a valid blockquote tag
Add a link to the Curriculum Development Handbook in _includes/links.md

Best, V

Note: this will fix #321

vinisalazar commented 3 years ago

Hi @maxim-belkin, thank you for the review. I applied the changes you've requested in f6ab50e. I needed to reset a few commits so I did that and force pushed a new commit with the requested changes. Please let me know if there are any more problems.

maxim-belkin commented 3 years ago

@zkamvar @fmichonneau, the PR looks good to me. The only issue that I can't comment on is the changes to the _episodes/05-rmarkdown-example.md file -- it's autogenerated so I'm not sure if it makes sense to change it or not.

vinisalazar commented 3 years ago

Hi @zkamvar, thank you for your review. I applied the requested changes. Please, let me know what you think.

Best, V