search

carpentries / lesson-example

Example lesson using The Carpentries lesson template.
https://carpentries.github.io/lesson-example/
Other
64 stars 173 forks source link

404 page does not render correctly for any arbitrary invalid URL #335

Closed jhlegarreta closed 3 years ago

jhlegarreta commented 3 years ago

The 404 page seems to work correctly when introducing an invalid URL from the main page, e.g. https://carpentries.github.io/lesson-example/random

However, the style is not correctly applied when introducing an invalid URL from any other page/episode or any other part of the URL, e.g. https://carpentries.github.io/lesson-example/03-organization/index1.html https://carpentries.github.io/lesson-example/03-organization1/index.html

maxim-belkin commented 3 years ago

Thanks @jhlegarreta. Could you please submit the issue (and the fix) to carpentries/styles?

jhlegarreta commented 3 years ago

@maxim-belkin Unfortunately, I do not know what the fix is :pensive:, but I can open the issue in the carpentries/styles and close it here if that is the right place for the issue.

maxim-belkin commented 3 years ago

Ah, OK. I assumed that the linked (merged) pr has a fix. Yes, please submit it to carpentries/styles.

jhlegarreta commented 3 years ago

Keeping track of the issue in https://github.com/carpentries/styles/issues/568

Closing.