search

carpentries / lesson-example

Example lesson using The Carpentries lesson template.
https://carpentries.github.io/lesson-example/
Other
64 stars 173 forks source link

Update Styles (2021-10-20 via ) #363

Closed carpentries-bot closed 3 years ago

carpentries-bot commented 3 years ago

Update styles repository. Please inspect the changes to make sure there are no conflicts with your lesson.

zkamvar commented 3 years ago

Oh noes! For some reason, this is trying to pull in changes from the main branch????

zkamvar commented 3 years ago

Situation

This PR was incorrectly bringing in changes from carpentries/styles@main, which would have removed the README.md file.

Cause

This was caused by the change of the default branch in this repository from gh-pages to main. Because the action had the ${{ github.ref }} variable defining the REF environment variable, it was pulling that ref from the styles repository:

https://github.com/carpentries/lesson-example/blob/01b7c550e599345a08f8a9a05b73e8224fd1c474/.github/workflows/update-styles.yml#L61-L68

Solution

I did the following:

  1. closed this PR
  2. created a quick fix in the actions repository: https://github.com/carpentries/actions/commit/f0e610d6daa7263617d4dd0909c805e810c490cd
  3. re-started this workflow manually from the actions tab to create #364