search

carpentries / lesson-infrastructure

4 stars 3 forks source link

Requiring Git for Windows >= v2.15.1 in our workshops #5

Open fmichonneau opened 6 years ago

fmichonneau commented 6 years ago

Initial proposal by @rgaiacs available here: https://github.com/carpentries/lesson-infrastructure/blob/master/liep/001-git-for-windows-nano.md

fmichonneau commented 6 years ago

This is a great proposal that would make things easier for all our learners.

I'm wondering if we shouldn't at the same time organize the restructuring of the setup instructions to minimize the amount of work it will take to ensure that the setup instructions are up to date everywhere.

rgaiacs commented 6 years ago

I'm wondering if we shouldn't at the same time organize the restructuring of the setup instructions to minimize the amount of work it will take to ensure that the setup instructions are up to date everywhere.

Can you clarify this?

http://swcarpentry.github.io/shell-novice/setup.html and http://swcarpentry.github.io/git-novice/setup/ doesn't have any installation instructions at the moment. They only keep some post installation notes. I listed all lessons so that someone can check that we didn't leave some old information.

fmichonneau commented 6 years ago

I tested the installation instructions in the original pull request referenced in this proposal. They work well and I think it's the right approach.

As mentioned in the proposal, the drawbacks are:

Both of these drawbacks seem reasonable.

I propose we move this proposal forward.

rgaiacs commented 6 years ago

I propose we move this proposal forward.

Can you include this on today's maintainers meeting? Thanks.

justinclift commented 6 years ago

As a general thought, the proposal seems to bundle some SQLite changes in there as well. Those bits might need a bit of adjustment now that a different (GUI) approach to using SQLite seems to have generally been adopted: https://github.com/datacarpentry/sql-ecology-lesson/issues/199

rgaiacs commented 6 years ago

@fmichonneau Any update on this one?

fmichonneau commented 6 years ago

I just got back from another conference. I'll work on this early next week.