datacarpentry/openrefine-socialsci

[zkamvar]

tracking issues for https://github.com/datacarpentry/openrefine-socialsci/

• [x] link issues

  index.md:34 [missing file]: [Setup](setup.html)
  index.md:53 [missing file]: [Instructor notes](guide/)

• [x] fix callout in setup list (note: this is likely similar to the setup callout issues in #46)
• [x] fix first title appearing above questions/objectives (fixed in https://github.com/carpentries/pegboard/pull/124)
• [x] fix setup instructions (this may have been fixed with https://github.com/carpentries/pegboard/issues/120), but I need to find the correct place for these links
• [x] investigate encroachig solution in callout block (for maintainers to address how they want to do this either via https://github.com/carpentries/lesson-transition/issues/46#issuecomment-1522014660 or by transforming point 6 into a callout under point 5 and appending the solution)

[bencomp]

First: thanks for your efforts! Looking at the preview in Firefox for Android, I notice a few things.

Callouts are not (always?) translated into new style callouts.

First section title appears above objectives.

A link text and the link itself are mangled: [instructions... Space between two inline preformatted strings - "get data from" and "this computer" - is invisible (or removed, I cannot tell on mobile).

"Show me the solution" partially obscures body text.

I noticed that the last episode links to the start with another "next" link. Is that intentional?

[zkamvar]

Hi @bencomp, thank you for your patience. I have gone through the issues you have pointed out and most of them have been fixed! The only two that remain are the untranslated callout block (this I will fix) and the encroaching solution block.

I apologise for the solution block kerfuffle, but unfortunatley, they are a bit more buoyant in the workbench. The solution is to give them another callout block or div to glom onto. My suggestion would be, after the transition, combine the 5th and 6th points into a discussion/solution block, which will end up like this:

This is how you would code it (note the indent of 3 spaces to maintain the list item block):

5. Hover the mouse over one of the names in the `Facet` list. You should see
   that you have an `edit` function available.

   ::::::::::::::: discussion

   ### Better ways to fix errors

   You could use this to fix an error immediately, and OpenRefine will ask
   whether you want to make the same correction to every value it finds like
   that one. But OpenRefine offers even better ways to find and fix these
   errors, which we'll use instead. We'll learn about these when we talk about
   clustering.

   ::::::::::::::::::::::::::

   :::::::::::::::  solution

   ### Available alternatives

   - `Chirdozo` is likely a mis-entry of `Chirodzo`.
   - `Ruca` is likely a mis-entry of `Ruaca`.
   - `Ruaca - Nhamuenda` and `Ruaca-Nhamuenda` refer to the same place (differ
     only by spaces around the hyphen). You might also wonder if both of these
     are the same as `Ruaca`. We will see how to correct these misspelled and
     mistyped entries in a later exercise.
   - The entry `49` is almost certainly an error but you will not be able to fix
     it by reference to other data.

   :::::::::::::::::::::::::

[bencomp]

Hi @zkamvar, thanks for fixing the issues and commenting. I did indeed notice that some things looked better already :)

I think the encroaching block is also related to #datacarpentry/openrefine-socialsci#121 – as we have a solution without corresponding exercise. I will have a look at transforming the whole thing into exercise+solution, or following your solution.

[zkamvar]

That's great! I will comment within the next hour about the transition once I run my tests.

[zkamvar]

fixed in a36c90ea88fd46dd10bed7bcfc116e1678bef116