carpentries / sandpaper-docs

Documentation for The Carpentries Workbench
https://carpentries.github.io/sandpaper-docs/
Other
5 stars 45 forks source link

pin to digest v0.6.33 #152

Closed tobyhodges closed 1 year ago

tobyhodges commented 1 year ago

Resolves #150

Running sandpaper::pin_version("digest@0.6.33") seems to have changed more than only the version of digest. @zkamvar please can you confirm that everything is as expected?

github-actions[bot] commented 1 year ago

Thank you!

Thank you for your pull request :smiley:

:robot: This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

Rendered Changes

:mag: Inspect the changes: https://github.com/carpentries/sandpaper-docs/compare/md-outputs..md-outputs-PR-152

The following changes were observed in the rendered markdown documents:

 config.yaml (gone) |  91 ------------
 episodes.md        |  62 --------
 md5sum.txt         |  42 +++---
 renv.lock (gone)   | 410 -----------------------------------------------------
 4 files changed, 21 insertions(+), 584 deletions(-)
What does this mean? If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

:stopwatch: Updated at 2023-08-02 15:53:44 +0000

zkamvar commented 1 year ago

Running sandpaper::pin_version("digest@0.6.33") seems to have changed more than only the version of digest.

Yes. This looks fine. No other package versions have changed, only the metadata from {renv}.

This is partially because we use three sources for R packages as fallbacks so that we can get the latest binary version of a package. As long as the diffs do not show anything out of the ordinary, it's okay.