search

carpentries / sandpaper

User Interface for The Carpentries Workbench
https://carpentries.github.io/sandpaper
Other
41 stars 26 forks source link

finalise translate tests #560

Closed zkamvar closed 7 months ago

zkamvar commented 7 months ago

This refactors the translation tests a bit more to ensure that we are only using the keys and not the values to test translations. This will help future-proof the tests.

Improving on #559, I've added tr_varnish() and tr_computed() to the internal functions so we can replace the awkward these$translations$varnish$KeyPoints with tr_varnish("KeyPoints"). This will make it easier for us to shift to a different internal storage name and also for us to continue to detect translation functions in the future.

zkamvar commented 7 months ago

I am satistifed with this and will let it merge