search

carpentries / sandpaper

User Interface for The Carpentries Workbench
https://carpentries.github.io/sandpaper
Other
42 stars 28 forks source link

Adding Caution Callout #613

Closed MttArmstrong closed 2 weeks ago

MttArmstrong commented 1 month ago

When translating old modules, I noticed that the "Caution" callout is excluded in the new varnish/sandpaper packages.

If this was unintentional, I have prepared this PR to re-add this callout to Sandpaper, and have submitted a similar PR to Varnish as well.

This issue was also reported in the sandpaper-docs repo (https://github.com/carpentries/sandpaper-docs/issues/179)

froggleston commented 4 weeks ago

Looks good! I think the only thing remaining is to generate the potools files to take into account the new translation keyword for caution callouts.

MttArmstrong commented 3 weeks ago

Looks good! I think the only thing remaining is to generate the potools files to take into account the new translation keyword for caution callouts.

I believe I have updated the correct files! Please let me know if there is anything else I should do!