search

carpentries / styles

Styles for The Carpentries lessons. No README to avoid merge conflicts with lessons. Demo 👇
https://carpentries.github.io/lesson-example
Other
85 stars 96 forks source link

"Edit on GitHub" doesn't work when rendered locally #352

Open fmichonneau opened 6 years ago

fmichonneau commented 6 years ago

When the website is rendered locally, the "Edit on GitHub" links don't work.

In the template, the links needed to make this to work use data from the GitHub API through the github-metadata Jekyll plugin. Unless the user who tries to render the site locally has a GitHub PAT available as an environment variable, the metadata are not available to create a functioning link.

Is there a reasonable way to make the link work locally without relying on GitHub metadata?

rgaiacs commented 6 years ago

Is there a reasonable way to make the link work locally without relying on GitHub metadata?

No.

rgaiacs commented 5 years ago

@fmichonneau Did you fixed this? I remember a pull request related to this.

pawsey-kbuckley commented 5 years ago

I believe that this is another issue, related to offline browsing, that was "solved" two years ago, but for which the same solution is now documented in a more up to date revision:

https://pawsey-kbuckley.github.io/offline-capable-lesson