carpentries / styles

Styles for The Carpentries lessons. No README to avoid merge conflicts with lessons. Demo 👇
https://carpentries.github.io/lesson-example
Other
86 stars 97 forks source link

Cite link doesn't work when rendered locally #418

Open pawsey-kbuckley opened 5 years ago

pawsey-kbuckley commented 5 years ago

Basically, the "Cite" link in the footer menu gets rendered as

file:///blob/CITATION

This is yet another issue that was identified, and for which a potential solution was identifed, some two years ago, in this work:

https://vuw-ecs-kevin.github.io/offline-capable-lesson/03-use-local-content/index.html

but which is now addressed in a newer revision of that same work:

https://pawsey-kbuckley.github.io/offline-capable-lesson/03-use-local-content/index.html

This issue relates to

Interestingly, it seems that this type of issue was known about, but not addressed, much earlier (2016) in the history of the Carpentries

so it would be nice to finally draw a line under it.

pawsey-kbuckley commented 5 years ago

I believe this commit

https://github.com/pawsey-kbuckley/offline-capable-lesson/commit/dd8f2a6453b59c918eee1abb6af0e1aa58966665

does what's required but am not sure is I should create seperate PRs for each commit in the work that address a single issue, of if there's a way to just get the styles repo to incorporate them all ?