Closed maxim-belkin closed 3 years ago
Thanks Maxim!
Thanks, François!
@jhlegarreta, could you please confirm that after this change make lesson-check-all
doesn't complain about the long lines that contain images or links only?
The regex does not seem straightforward ! Thanks both :+1:.
@jhlegarreta, could you please confirm that after this change make lesson-check-all doesn't complain about the long lines that contain images or links only?
Will give it a try when I find the time (will try during the weekend) and will report back.
Unfortunately, it does not look like it solved the issue. In fact, the number of warnings has increased, e.g.: https://github.com/carpentries-incubator/SDC-BIDS-dMRI/runs/2531577900?check_suite_focus=true#step:16:20 with respect to an immediately previous version, e.g. https://github.com/carpentries-incubator/SDC-BIDS-dMRI/runs/2528767166?check_suite_focus=true#step:16:20
In the previous version, link-only lines (e.g. line 190 at the pointed file - __episodes/constrained_spherical_deconvolution.md
) were not triggering warnings, and now they are. Meanwhile, the lines that made me open (e.g. line 458) the issue are still raising the warnings.
Oh, I see what the problem is. The pattern I added doesn't allow {:class ...}
at the end. I'll fix that.
So, I found a few things that you use in your lesson that I didn't take into account when I was working on this pattern:
{:class=...}
customizations in link/image-only lines\
at the end of the image/link-only linesSo, #597 should address all of these.
Allow lines that contain a single image or a single link to go over the suggested line length limit. So, all of the following lines will be allowed to go over the line limit:
Plus all of the above prefixed with any combination of
to allow these lines to go over the limit in various code blocks.
>
andFixes carpentries/styles#591